Adding SSO CILogon #872
Merged
Adding SSO CILogon #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… more modifications
Adding some missing methods and start cleanup. We still need to clean up and fix the `openid_connect` method on `omniauth_callbacks_controller.rb`.
Here we have a first pass of working integration tests for omniauth SSO. The tests still need to check for the messages we are setting as notifications. We can think about splitting the tests into integration and controller tests.
aaronskiba
reviewed
Sep 6, 2024
app/views/devise/registrations/_external_openid_connect.html.erb
Outdated
Show resolved
Hide resolved
| expect(identifiable.surname).to_not eql('Doe') | ||
|
|
||
| # XXX Check for flash notice message linked successfully | ||
| # expect(page).to have_content('Linked succesfully') |
There was a problem hiding this comment.
For it to run during workflows, I think spec/integration/openid_connect_sso_test.rb needs to be renamed to spec/integration/openid_connect_sso_spec.rb. https://github.com/rspec/rspec-rails?tab=readme-ov-file#running-specs
aaronskiba
reviewed
Sep 6, 2024
app/views/devise/registrations/_external_openid_connect.html.erb
Outdated
Show resolved
Hide resolved
About and Help page changes related to the SSO updates #877
aaronskiba
reviewed
Sep 6, 2024
Commit f76758b - "Add link account with CILogon" added the functionality to link an external account via CILogon. However, the commit also removed the functionality to link one's ORCID credentials within the app. This commit adds the ORCID functionality back.
We previously had methods that were dynamically created but are no longer needed since we are creating them specifically. This is done to handle the different workflow for CILogon account creation.
Patch to Put Back ORCID Linking Functionality
Testcases for the Ominiauth controller openid connect
Change was requested here: #888 (comment)
aaronskiba
force-pushed
the
yashu-sso-link-accounts
branch
from
5e0134f
to
d30ed72
Compare
Release `4.1.1+portage-4.2.0` includes a migration and it requires a specific new entry to the `identifier_schemes` table for openid_connect / CILogon to work properly. This rake task is intended to take care of all of that. Note: The changes applied via this rake task have already been executed manually on the staging environment. However, performing the rake task on staging should still have no adverse effects.
…ade-task Add Rake Task For `4.1.1+portage-4.2.0` Upgrade
aaronskiba
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the combined efforts to add SSO to DMP Assistant.
Will be cleaning the PR and submit at a later time