Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Carriage Return Issue When Uploading DB Fields to Translation.io #524

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

aaronskiba
Copy link
Collaborator

Fixes #523

Changes proposed in this PR:

  • This PR addresses the \r issue that was occurring when syncing db values to translation.io
  • The target branch for the translation gem has been changed. It is based off of the previous fix/broken_db_fake_method_calls and adds one additional change via the following commit: ualbertalib/translation_io_rails@5fb2d5c
  • The extra Gemfile.lock changes are the result of running bundle install after replacing the translation target branch in Gemfile

'fix/carriage-return-issue' branch is based off the previous branch 'fix/broken_db_fake_method_calls'
This commit does not change the behaviour of the app. Rather, the carriage-return-issue branch was merged into the broken_db_fake_method_calls branch.
Copy link
Collaborator

@200455939-yashu 200455939-yashu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Work 👏

@aaronskiba aaronskiba merged commit 6eb45bc into deployment-portage Nov 20, 2023
14 checks passed
@aaronskiba aaronskiba deleted the aaron/issues/523 branch November 20, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Carriage Return Issue When Uploading db fields to translation.io
2 participants