Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bootstrap-select stylesheet back after version 3 upgrade to fix the option-picker UI bug #207

Merged
merged 2 commits into from
May 27, 2022

Conversation

pengyin-shan
Copy link

@pengyin-shan pengyin-shan commented May 27, 2022

Fixes #195

Changes proposed in this PR:

The boostrap-select stylesheet is commented out in 8bd0968.

Since we finish the the 3.0 upgrade, add the boostrap-select stylesheet back, because related styles are used in creating questions and currently causing an UI issue.

OPTIONAL: since we are having constant complaints from brakeman about the EOL security warning, I switched to an 'ingore warning' flag to make the test pass (ERROR will still be reported). We can use this option or keep the brakeman as it is now till we finish the rails upgrade.

@pengyin-shan pengyin-shan changed the title Draft: Add bootstrap-select stylesheet back after version 3 upgrade to fix the option-picker UI bug Add bootstrap-select stylesheet back after version 3 upgrade to fix the option-picker UI bug May 27, 2022
@pengyin-shan pengyin-shan marked this pull request as ready for review May 27, 2022 20:25
@pengyin-shan pengyin-shan requested a review from lagoan May 27, 2022 20:25
Copy link
Collaborator

@lagoan lagoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pengyin-shan pengyin-shan merged commit c6dd25d into integration May 27, 2022
@pengyin-shan pengyin-shan deleted the issue195 branch May 27, 2022 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants