Issue202: Add contributor to the DMP downloaded files #206
Conversation
Generated by 🚫 Danger |
|
Meanwhile, I submitted an issue to DMPRoadmap: DMPRoadmap#3179 about the problem we have in the related rspec file. |
| @@ -46,6 +46,13 @@ def show | |||
| @selected_phase = @plan.phases.order("phases.updated_at DESC") | |||
| .detect { |p| p.visibility_allowed?(@plan) } | |||
| end | |||
|
|
|||
| #ISSUE205: add contributor to cover page | |||
There was a problem hiding this comment.
We should add explanation to the behaviour of the code instead of referencing the issue number of the repository. If we ever change repositories the issue number will no longer make sense.
There was a problem hiding this comment.
We should also add tests to make sure all the people listed actually show up on the reports.
Yeah, I was also considering this. I submitted the issue DMPRoadmap#3179 to DMPRoadmap because our current way of testing is not tracking the downloaded file, instead, it is just tracking the original page source.
So far I haven't figured out the best way of asking RSpec to track the content of the 'downloaded file' (i.e. docx, csv, pdf..) because it is part of the user's computer instead of the rails program. I will continue to think about it. Please let me know if you know anything I can refer it.
| #ISSUE205: add contributor to cover page | ||
| hash[:data_curation] = Contributor.where(:plan_id => id).data_curation | ||
| hash[:investigation] = Contributor.where(:plan_id => id).investigation | ||
| hash[:pa] = Contributor.where(:plan_id => id).project_administration | ||
| hash[:other] = Contributor.where(:plan_id => id).other |
| @@ -7,6 +7,21 @@ | |||
| <%# Allow raw html (==) for plan_attribution as it has <b> tags %> | |||
| <p><%== plan_attribution(@hash[:attribution]) %></p><br> | |||
|
|
|||
| <%# ISSUE205: print out contributors if exit %> | |||
There was a problem hiding this comment.
Same as comment about referencing repository issues.
| @@ -7,6 +7,21 @@ | |||
| <%# Allow raw html (==) for plan_attribution as it has <b> tags %> | |||
| <p><%== plan_attribution(@hash[:attribution]) %></p><br> | |||
|
|
|||
| <%# ISSUE205: print out contributors if exit %> | |||
| <%# Roles are ranked by PI -> DM -> PA -> Other (if any) %> | |||
There was a problem hiding this comment.
This is a good explanation of the behaviour of the view!
| <%= @hash[:attribution].many? ? _("Creators: ") : _('Creator:') %> <%= @hash[:attribution].join(', ') %> | ||
| <%# ISSUE205: print out contributors if exit %> |
|
We should also add tests to make sure all the people listed actually show up on the reports. |
Fixes #202 .
Changes proposed in this PR:
"contributor":[{"name":"Wendy Shan Both","mbox":"[email protected]","role":["http://credit.niso.org/contributor-roles//data-curation","http://credit.niso.org/contributor-roles//investigation"],"affiliation":{"name":"University of British Columbia","abbreviation":"UBC","region":null}},{"name":"Wendy Shan","mbox":"[email protected]","role":["http://credit.niso.org/contributor-roles//investigation","other"],"affiliation":{"name":"University of British Columbia","abbreviation":"UBC","region":null}}]