Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent routing for Terms of Use and How To Manage Your Data #397

Closed
aaronskiba opened this issue Jul 24, 2023 · 0 comments
Closed

Comments

@aaronskiba
Copy link
Collaborator

Currently, def terms_of_use_path and def how_to_manage_your_data_path exist in application_helper.rb for providing en/fr localized routes. However, the usage of these localized routes is inconsistent.

The file _create_account_form.html.erb uses terms_of_use_path. However, the file _footer.html.erb is hardcoded with <a href="/terms"><%= _('Terms of use') %></a>.

The file help.html.erb uses how_to_manage_your_data_path. However, the file _welcome.html.erb is hardcoded with <a href="https://portagenetwork.ca/tools-and-resources/dmp-assistant/how-to-manage-your-data/">How to Manage Your Data</a>.

aaronskiba added a commit that referenced this issue Jul 24, 2023
Commit affects how "Terms of Use" is routed in footer and how "How to Manage Your Data" is routed on homepage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant