Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSpec test for download plan needed #153

Closed
2 of 3 tasks
pengyin-shan opened this issue Mar 4, 2022 · 2 comments
Closed
2 of 3 tasks

RSpec test for download plan needed #153

pengyin-shan opened this issue Mar 4, 2022 · 2 comments
Assignees
@pengyin-shan
Labels
bug Something isn't working high priority

Comments

@pengyin-shan
Copy link

pengyin-shan commented Mar 4, 2022 •
edited
Loading

JSON on the production server also reports a different bug. Might not be the same issue

  • Function Download

  • JSON only issue

  • RSpec test
@pengyin-shan pengyin-shan added the bug Something isn't working label Mar 4, 2022
@pengyin-shan pengyin-shan self-assigned this Mar 4, 2022
@pengyin-shan pengyin-shan mentioned this issue Mar 4, 2022
Merged
@pengyin-shan pengyin-shan changed the title Empty content for plan downloading, single phase only JSON download plan not work for prod and staging & RSpec test for download plan needed Apr 4, 2022
@pengyin-shan
Copy link
Author

JSON download works after a test Rails.application.routes.default_url_options[:host] added to environment file. Updated on v3.0.10

@pengyin-shan pengyin-shan changed the title JSON download plan not work for prod and staging & RSpec test for download plan needed RSpec test for download plan needed Apr 22, 2022
@pengyin-shan
Copy link
Author

Close this ticket. The RSpec test for download relates to an issue from the main codebase. I have submitted the issue at DMPRoadmap#3179. For anyone who gonna work on this, please make sure you also submit your solution to roadmap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pengyin-shan pengyin-shan

Labels
bug Something isn't working high priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lagoan @pengyin-shan