Fix the issue of download plans (only coverpage can be downloaded) #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lagoan
reviewed
Mar 4, 2022
CHANGELOG.md
Outdated
| @@ -1,5 +1,8 @@ | |||
| # Changelog | |||
|
|
|||
| ## [3.0.4+portage-3.0.5] | |||
| - Fixed pdf download issue | |||
There was a problem hiding this comment.
We need to add this on the CHANGELOG under a new version.
Also, we need to be under a subheading for FIXED.
Now that we are keeping better track of issues we should start adding links to the issue being fixed #153
You can see jupiter's CHANGELOG as an example
There was a problem hiding this comment.
Working on it : ) should I put today as the release date?
lagoan
reviewed
Mar 4, 2022
| @@ -111,7 +111,7 @@ | |||
| options_for_select(Settings::Template::VALID_MARGIN_RANGE.to_a, | |||
| @export_settings.formatting[:margin][:right]), | |||
| class: 'form-control', | |||
| "data-default": @plan.template.settings(:export).formatting[:margin][:rigth] %> | |||
| "data-default": @plan.template.settings(:export).formatting[:margin][:right] %> | |||
lagoan
requested changes
Mar 4, 2022
lagoan
reviewed
Mar 4, 2022
config/environments/development.rb
Outdated
| @@ -71,4 +71,4 @@ | |||
| end | |||
|
|
|||
| # Used by Rails' routes url_helpers (typically when including a link in an email) | |||
| Rails.application.routes.default_url_options[:host] = "localhost:3000" | |||
| # Rails.application.routes.default_url_options[:host] = "localhost:3000" | |||
There was a problem hiding this comment.
Is this line part of the problem for this issue?
Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of #153 .
This PR does not include JSON issue (unique on production and staging) and functional tests. JSON issue might be a configuration issue, will do further navigation after this emergency release. The functional test will come soon.