Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mods folder not created automatically #17

Closed
wshadow opened this issue May 4, 2016 · 2 comments
Closed

mods folder not created automatically #17

wshadow opened this issue May 4, 2016 · 2 comments

Comments

@wshadow
Copy link

wshadow commented May 4, 2016

I used the version from #6 to avoid the issue described in #5. The download failed, because the mods folder didn't exist yet and the downloaded mod could therefore not be saved there. Manually adding the folder at the correct location solved the issue.

./downloader.py --manifest ./NFINIT/manifest.json --nogui
137 files to download
[1/137] ActuallyAdditions-1.8.9-r26.jar
Traceback (most recent call last):
File "./downloader.py", line 192, in
doDownload(args.manifest)
File "./downloader.py", line 148, in doDownload
with open(mod_filename, "wb") as mod:
FileNotFoundError: [Errno 2] No such file or directory: 'NFINIT/minecraft/mods/ActuallyAdditions-1.8.9-r26.jar'

@iarspider
Copy link
Contributor

I believe this happens if "minecraft" folder exists, but "minecraft/mods" doesn't.

@TOLoneWolf
Copy link

yeah looks like making a mods folder got put inside the code that makes the minecraft folder, so if it doesn't need to make a minecraft folder it skips that line as well.
https://github.com/portablejim/curseDownloader/blob/master/downloader.py#L119-L121

codewarrior0 added a commit to codewarrior0/curseDownloader that referenced this issue Aug 20, 2016
Fixes an error if `minecraft/` exists but `minecraft/mods/` does not.
portablejim added a commit that referenced this issue Aug 28, 2016
Fix #17: No such file or directory: minecraft/mods/
TOLoneWolf pushed a commit to TOLoneWolf/curseDownloader that referenced this issue Nov 2, 2016
# Conflicts:
#	downloader.py
Update to sync fork with master so there will be no merge conflicts over how portablejim#17 was fixed previously in this fork with the pull requested way in master.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants