-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Integration][GCP] Added an alternative for retrieving quota project id #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matan84
requested changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requested changes
matan84
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What
This PR fixes a bug related to fetching the GCP project ID from service account credentials. Previously, the function would fail to retrieve the correct project ID when the
quota_project_id
key was missing from the credentials file.Why
GCP configuration differs based on how the credentials are generated. When using
gcloud auth application-default login
, the project ID is stored under thequota_project_id
key. However, when a service account key is generated from the console, the project ID is stored under theproject_id
key. This discrepancy caused the integration to fail in identifying the project ID when the credentials were generated from the console, impacting quota computation operations.This bug affected users by causing failures in environments where
quota_project_id
was not available. The fix ensures that both configurations are supported, making the application more robust and reliable in different environments.How
project_id
andquota_project_id
keys in the credentials file.Type of change
Please leave one option from the following and delete the rest:
All tests should be run against the port production environment(using a testing org).
Integration testing checklist
examples
folder in the integration directory.