-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Datadog] Add custom tag names for metric filters #962
Merged
Tankilevitch
merged 16 commits into
main
from
PORT-10137-allow-custom-tag-specification-in-datadog-metrics-kind-selector
Sep 2, 2024
Merged
[Datadog] Add custom tag names for metric filters #962
Tankilevitch
merged 16 commits into
main
from
PORT-10137-allow-custom-tag-specification-in-datadog-metrics-kind-selector
Sep 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tankilevitch
requested changes
Aug 29, 2024
- Move configuration handling from DatadogClient to main.py - Update get_metrics method signature in client.py - Modify on_resync_service_metrics in main.py to handle configuration - Add get_metric_config helper function in main.py - Improve separation of concerns between client and main application logic
phalbert
force-pushed
the
PORT-10137-allow-custom-tag-specification-in-datadog-metrics-kind-selector
branch
from
August 30, 2024 13:57
db1d4e4
to
3ee93c8
Compare
PeyGis
requested changes
Aug 30, 2024
Tankilevitch
reviewed
Sep 1, 2024
…-datadog-metrics-kind-selector
Tankilevitch
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tankilevitch
deleted the
PORT-10137-allow-custom-tag-specification-in-datadog-metrics-kind-selector
branch
September 2, 2024 11:05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a feature that allows clients to specify custom tag names for hosts, in addition to the default universal Datadog tags (env and service). This enhancement provides flexibility for clients who have hosts tagged with different tags than the default ones used by Datadog.
Description
The current system defaults to using the universal Datadog tags env and service for host identification and selection. However, some clients (e.g., IU) may have hosts tagged with different tags. To address this need, the following changes have been made:
datadogSelector
configuration to include fields for specifying custom tags.Additional Notes
Type of change
Please leave one option from the following and delete the rest:
All tests should be run against the port production environment(using a testing org).
Core testing checklist
Integration testing checklist
examples
folder in the integration directory.Preflight checklist
Screenshots
Include screenshots from your environment showing how the resources of the integration will look.
API Documentation
Provide links to the API documentation used for this integration.