Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gitlab] Improvements to file kind #942

Merged
merged 33 commits into from
Sep 4, 2024
Merged

[Gitlab] Improvements to file kind #942

merged 33 commits into from
Sep 4, 2024

Conversation

matan84
Copy link
Member

@matan84 matan84 commented Aug 25, 2024 •
edited
Loading

Description

What - Added improvements in resync + realtime analysis for file-kind.
Why - Have better scale, performance and verbosity for the feature
How - In resync- add a search in all repositories being processed, making sure the path we need is present in the repo, and only then the integration will pull the file. In real-time - added pagination for verbosity

Type of change

Please leave one option from the following and delete the rest:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New Integration (non-breaking change which adds a new integration)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Non-breaking change (fix of existing functionality that will not change current behavior)
  • Documentation (added/updated documentation)

Screenshots

Include screenshots from your environment showing how the resources of the integration will look.

API Documentation

Provide links to the API documentation used for this integration.

@matan84 matan84 requested a review from a team as a code owner August 25, 2024 14:56
@github-actions github-actions bot added size/L and removed size/M labels Aug 25, 2024
@matan84 matan84 changed the title Added pagination to gitlab's file iteration [Gitlab] Added pagination to gitlab's file iteration Aug 26, 2024
PeyGis
PeyGis approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@PeyGis PeyGis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PeyGis
PeyGis requested changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@PeyGis PeyGis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one comment

integrations/gitlab/gitlab_integration/gitlab_service.py Outdated Show resolved Hide resolved
@matan84 matan84 changed the title [Gitlab] Added pagination to gitlab's file iteration [Gitlab] Improvements to file kind Aug 28, 2024
PeyGis
PeyGis approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@PeyGis PeyGis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one question

integrations/gitlab/gitlab_integration/gitlab_service.py Show resolved Hide resolved
@github-actions github-actions bot added size/M and removed size/L labels Sep 1, 2024
@github-actions github-actions bot added size/L and removed size/M labels Sep 2, 2024
Tankilevitch
Tankilevitch approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@Tankilevitch Tankilevitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 🚀 @matan84

@matan84 matan84 merged commit 4919d9b into main Sep 4, 2024
15 checks passed
@matan84 matan84 deleted the gitlab-file-kind-bugfix branch September 4, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tankilevitch Tankilevitch Tankilevitch approved these changes

@PeyGis PeyGis PeyGis approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matan84 @PeyGis @Tankilevitch