PORT-5598 | Jira integration - support sprints | Change priority to name #804
Conversation
lordsarcastic
changed the title
|
Can you add screenshots to the description ? |
Nothing's impossible. I'll write some tests for it then |
| INTEGRATION_PATH = os.path.abspath(os.path.join(os.path.dirname(__file__), "../")) | ||
|
|
||
|
|
||
| async def test_full_sync_using_mocked_3rd_party( |
There was a problem hiding this comment.
rename method for what exactly you are testing
| "calculationProperties": {} | ||
| "mirrorProperties": {}, | ||
| "calculationProperties": {}, | ||
| "relations": {} | ||
| }, | ||
| { | ||
| "identifier": "jiraIssue", |
There was a problem hiding this comment.
I am thinking maybe we should add a property with sprint, where the description of the property will point the user to the docs?
| - Added a field to display total issues in a project (0.1.96) | ||
| - Added support for ingesting other fields apart from the default fields (Jira Sprint support) (0.1.96) | ||
|
|
||
| ### Improvements | ||
|
|
||
| - Changed issue priority from id to name (0.1.96) |
There was a problem hiding this comment.
| - Added a field to display total issues in a project (0.1.96) | |
| - Added support for ingesting other fields apart from the default fields (Jira Sprint support) (0.1.96) | |
| ### Improvements | |
| - Changed issue priority from id to name (0.1.96) | |
| - Added a field to display total issues in a project | |
| - Added support for ingesting other fields apart from the default fields (Jira Sprint support) | |
| ### Improvements | |
| - Changed issue priority from id to name |
| @@ -20,7 +33,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| ### Improvements | |||
|
|
|||
| - Bumped ocean version to ^0.12.6 | |||
| - Bumped ocean version to ^0.12.6 (0.1.94) | |||
There was a problem hiding this comment.
| - Bumped ocean version to ^0.12.6 (0.1.94) | |
| - Bumped ocean version to ^0.12.6 |
There was a problem hiding this comment.
test should include actual test of expected data and enrichments.
e.g.
testing that when passing a jql then its adds the jql to the query. When adding fields that those fields are being added to the entity and that you see the expected value.
| if delete_action: | ||
| issue = data["issue"] | ||
| else: | ||
| issue = await client.get_single_issue(data["issue"]["key"]) | ||
| await ocean_action(ObjectKind.ISSUE, [issue]) |
There was a problem hiding this comment.
I think we should perform a request to get the issue with the fields as well, so we don't override it with null once we receive an event.
Maybe JQL as well? as we might receive an event of an issue that we are not interested which in regular resync wouldn't been inserted, but in real time event it would've.
Description
priorityfield to use the priority name instead of the priority idType of change
More information can be found in the docs PR.