[Core] Replace pyjq with jq.py
#1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh this may finally solve the problems I have always had installing |
erikzaadi
reviewed
Sep 26, 2024
port_ocean/tests/core/handlers/entity_processor/test_jq_entity_processor.py
Outdated
Show resolved
Hide resolved
erikzaadi
reviewed
Sep 26, 2024
port_ocean/tests/core/handlers/entity_processor/test_jq_entity_processor.py
Outdated
Show resolved
Hide resolved
erikzaadi
reviewed
Sep 26, 2024
erikzaadi
reviewed
Sep 29, 2024
| value = await loop.run_in_executor(None, func.first) | ||
| execute_time = loop.time() - start_time - compile_time | ||
| logger.debug( | ||
| f"Search for pattern {execute_time:.2f} seconds, compile time {compile_time:.2f} seconds" |
There was a problem hiding this comment.
This is golden, I wonder if it's possible to also send the explicit metrics as values in addition to the debug log text
erikzaadi
reviewed
Sep 29, 2024
| @pytest.mark.asyncio | ||
| class TestJQEntityProcessor: | ||
|
|
||
| @pytest.fixture |
There was a problem hiding this comment.
Oh nice, closure automagically since it's in the test class?
If so, good practice that's worth sharing.
erikzaadi
reviewed
Sep 29, 2024
| @@ -78,6 +78,7 @@ types-python-dateutil = "^2.9.0.20240316" | |||
| types-pyyaml = "^6.0.12.10" | |||
| types-toml = "^0.10.8.6" | |||
| yamllint = "^1.32.0" | |||
| pytest-timeout = "^2.3.1" | |||
There was a problem hiding this comment.
Might be worth aligning this in all integrations + cookie cutter as well
erikzaadi
reviewed
Sep 29, 2024
| @@ -174,4 +175,4 @@ exclude = ''' | |||
| [tool.pytest.ini_options] | |||
| asyncio_mode = "auto" | |||
| asyncio_default_fixture_loop_scope = "function" | |||
| addopts = "-vv -n auto --ignore-glob='./integrations/*' ./port_ocean/tests" | |||
| addopts = "-vv -n auto --durations=10 --color=yes --ignore-glob='./integrations/*' ./port_ocean/tests" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What -
pyjqwithjq.pyINfilter not supported by ocean JQ processor #1001Why - Upgrades internal jq version to latest 1.7.1 from 1.5.1
How -
Type of change
Please leave one option from the following and delete the rest:
All tests should be run against the port production environment(using a testing org).
Core testing checklist
Integration testing checklist
examplesfolder in the integration directory.Preflight checklist
Screenshots
Include screenshots from your environment showing how the resources of the integration will look.
API Documentation
Provide links to the API documentation used for this integration.