Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type of the argument for toHTML method #51

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Fix type of the argument for toHTML method #51

merged 1 commit into from
Nov 6, 2023

Conversation

yorch
Copy link
Contributor

@yorch yorch commented Oct 24, 2023

🔗 Linked issue

#50

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

TypeScript type for the argument of the method toHTML is incorrect, since the implementation treats it as optional, but the type as required.

📝 Checklist

  • I have read the contribution guide.
  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@yorch yorch changed the title Fix type toHTML method argument Fix type toHTML method's argument Oct 24, 2023
@yorch yorch changed the title Fix type toHTML method's argument Fix type of the argument for toHTML method Oct 24, 2023
@thetutlage thetutlage self-requested a review November 6, 2023 04:37
@thetutlage thetutlage merged commit bef2df8 into poppinss:develop Nov 6, 2023
5 checks passed
@thetutlage
Copy link
Member

Thanks :)

@thetutlage thetutlage mentioned this pull request Nov 6, 2023
Closed
@yorch yorch deleted the patch-1 branch November 9, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thetutlage thetutlage Awaiting requested review from thetutlage

Assignees

@yorch yorch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yorch @thetutlage