Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add huawei support for charging thresholds #439

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

elevenhsoft
Copy link
Contributor

Hello,
This simply checks if device have charge control thresholds ability. In this case, it should works with most of the huawei laptops. Tested on my Matebook and it works.

@mmstick mmstick requested review from a team September 3, 2024 11:47
Copy link
Member

@leviport leviport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested charging thresholds on a lemp10 and an oryp12, and there are no regressions on either. I don't have a Huawei device to test with, so I'll defer to your testing on that front.

@mmstick mmstick merged commit 290805e into pop-os:master Sep 6, 2024
20 checks passed
@elevenhsoft
Copy link
Contributor Author

Thank you! I tested it again after apt update and yeah, it works after switching in battery applet 🥳

~ ❯ cat /sys/devices/platform/huawei-wmi/charge_control_thresholds 
70 80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants