fix: center plymouth when display resolutions != #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current scaling can be a bit strange with this PR. I will make a PR after this one that should fix plymouth scaling with multiple monitors of differing resolutions.
|
Moved #24 to here to fix branch name |
jackpot51
approved these changes
Nov 8, 2021
jacobgkau
approved these changes
Nov 8, 2021
There was a problem hiding this comment.
This gets the decryption prompt centered when using multiple displays of differing resolutions. On most machines that I tested, the prompt is sized to the largest display, so when using e.g. a 4k external display with a 1080p internal display, the prompt is larger than normal on the internal display, but is not cut off; this is an improvement over the non-centered prompt. (On darp7 with 20.04, the prompt was sized to the 1080p display, and was smaller than usual on the 4k display; this also isn't really an issue.) This does not affect the prompt's size on a single-display setup. Tested on 20.04, 21.04, and 21.10; tested on Intel and NVIDIA.
This was referenced Nov 12, 2021
This was
linked to
issues
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current scaling can be a bit strange with this PR. I will make a PR after this one that should fix plymouth scaling with multiple monitors of differing resolutions.