Increase max height #134
Merged
Increase max height #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a small amount of padding at the bottom of the scroll container, for consistency.
|
If you have time, can you test if this fixes your issue @ryanabx? |
With pleasure! When I'm off work 😇 |
|
Sorry for the ping, but just for the sake of some polish for the alpha, can this maybe be reviewed @wash2? The reason the height is larger than in the designs is that the buttons in the designs are 152x124, while the current buttons are a bit bigger (at least vertically). The height in the designs has a minor issue with 2-line names, since the letters go outside the highlight. The current buttons could maybe be shrunk slightly vertically (though not sure if that would look right with 2-line names), which might allow reducing the max height, but not sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #116, and maybe #89 (can't test this since it takes my entire screen at 200%, and only 2 rows fit).
Tuned the value to not have the highlight of the hovered app touch the edge, and to not be able to accidentally launch apps in the 4th row (when no icon is visible, but the top of the highlight is clickable).
Unrelated, but maybe a small issue on Pop: when running
sudo apt reinstall cosmic-*, this message is shownE: Unable to locate package cosmic-applibrary, which might be because the repo name is different from the package name in Pop.