-
-
Notifications
You must be signed in to change notification settings - Fork 344
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: incorrect signing on non-binary
- Loading branch information
Showing
1 changed file
with
29 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
diff --git a/node_modules/app-builder-lib/electron-osx-sign/util.js b/node_modules/app-builder-lib/electron-osx-sign/util.js | ||
index 107d8aa..4a6a354 100644 | ||
--- a/node_modules/app-builder-lib/electron-osx-sign/util.js | ||
+++ b/node_modules/app-builder-lib/electron-osx-sign/util.js | ||
@@ -202,12 +202,23 @@ module.exports.walkAsync = async function (dirPath) { | ||
const stat = await fs.lstat(filePath) | ||
if (stat.isFile()) { | ||
switch (path.extname(filePath)) { | ||
+ case '': // Binary | ||
+ if (path.basename(filePath)[0] !== '.') { | ||
+ return getFilePathIfBinaryAsync(filePath) | ||
+ } // Else reject hidden file | ||
+ break | ||
+ case '.dylib': // Dynamic library | ||
+ case '.node': // Native node addon | ||
+ return filePath | ||
case '.cstemp': // Temporary file generated from past codesign | ||
debuglog('Removing... ' + filePath) | ||
await fs.unlink(filePath) | ||
return | ||
default: | ||
- return getFilePathIfBinaryAsync(filePath) | ||
+ if (path.extname(filePath).indexOf(' ') >= 0) { | ||
+ // Still consider the file as binary if extension seems invalid | ||
+ return getFilePathIfBinaryAsync(filePath) | ||
+ } | ||
} | ||
} else if (stat.isDirectory() && !stat.isSymbolicLink()) { | ||
const result = await _walkAsync(filePath) |