Skip to content

Commit

Permalink
fix: incorrect signing on non-binary
Browse files Browse the repository at this point in the history
  • Loading branch information
gnattu committed Dec 19, 2020
1 parent f1d4222 commit 28abf87
Showing 1 changed file with 29 additions and 0 deletions.
29 changes: 29 additions & 0 deletions patches/app-builder-lib+22.10.3.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
diff --git a/node_modules/app-builder-lib/electron-osx-sign/util.js b/node_modules/app-builder-lib/electron-osx-sign/util.js
index 107d8aa..4a6a354 100644
--- a/node_modules/app-builder-lib/electron-osx-sign/util.js
+++ b/node_modules/app-builder-lib/electron-osx-sign/util.js
@@ -202,12 +202,23 @@ module.exports.walkAsync = async function (dirPath) {
const stat = await fs.lstat(filePath)
if (stat.isFile()) {
switch (path.extname(filePath)) {
+ case '': // Binary
+ if (path.basename(filePath)[0] !== '.') {
+ return getFilePathIfBinaryAsync(filePath)
+ } // Else reject hidden file
+ break
+ case '.dylib': // Dynamic library
+ case '.node': // Native node addon
+ return filePath
case '.cstemp': // Temporary file generated from past codesign
debuglog('Removing... ' + filePath)
await fs.unlink(filePath)
return
default:
- return getFilePathIfBinaryAsync(filePath)
+ if (path.extname(filePath).indexOf(' ') >= 0) {
+ // Still consider the file as binary if extension seems invalid
+ return getFilePathIfBinaryAsync(filePath)
+ }
}
} else if (stat.isDirectory() && !stat.isSymbolicLink()) {
const result = await _walkAsync(filePath)

0 comments on commit 28abf87

Please sign in to comment.