Fix code generation failure with tuples in recover blocks #2642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where code generation would fail when trying to convert a tuple from a recover block to an abstract type. This was occurring because the `gen_assign_cast` function was expecting the tuple to have the LLVM type corresponding to the Pony type outside of the recover block, but it was encountering the type from inside of the recover block. This was failing because we use different LLVM types for tuples with differing capabilities. Objects from recover blocks are now casted to the correct expected type before being handled to their user. Closes ponylang#2639.
Praetonus
added
the
changelog - fixed
jemc
approved these changes
Apr 11, 2018
ponylang-main
added a commit
that referenced
this pull request
Apr 11, 2018
dipinhora
pushed a commit
to dipinhora/ponyc
that referenced
this pull request
Jun 5, 2018
) This fixes a bug where code generation would fail when trying to convert a tuple from a recover block to an abstract type. This was occurring because the `gen_assign_cast` function was expecting the tuple to have the LLVM type corresponding to the Pony type outside of the recover block, but it was encountering the type from inside of the recover block. This was failing because we use different LLVM types for tuples with differing capabilities. Objects from recover blocks are now casted to the correct expected type before being handled to their user. Closes ponylang#2639.
dipinhora
pushed a commit
to dipinhora/ponyc
that referenced
this pull request
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where code generation would fail when trying to convert a tuple from a recover block to an abstract type. This was occurring because the
gen_assign_castfunction was expecting the tuple to have the LLVM type corresponding to the Pony type outside of the recover block, but it was encountering the type from inside of the recover block. This was failing because we use different LLVM types for tuples with differing capabilities.Objects from recover blocks are now casted to the correct expected type before being handled to their user.
Closes #2639.