Fix scheduler suspend edge case assertion #2641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jemc
approved these changes
Apr 10, 2018
|
Restarted appveyor build that failed with the following while downloading llvm: |
|
Hmmm... Apparently, it's an all or nothing rebuild on appveyor so all of the appveyor builds are re-running. 8*/ |
Prior to this commit, it was possible for a scheduler thread to suspend even though it wasn't appropriate to do so because another scheduler thread resumed prior to the lock being acquired. This would result in incorrect behavior in the release build and an assertion in the debug build. See the following link for an example of the assertion being triggered: https://circleci.com/gh/ponylang/ponyc/3809?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link This commit fixes the issue by not suspending if the schduler count changed because another thread resumed.
dipinhora
force-pushed
the
remove_sched_suspend_assertion
branch
from
a3ab554
to
a9fb0da
Compare
jemc
added
the
changelog - fixed
ponylang-main
added a commit
that referenced
this pull request
Apr 12, 2018
dipinhora
added a commit
to dipinhora/ponyc
that referenced
this pull request
Jun 5, 2018
Prior to this commit, it was possible for a scheduler thread to suspend even though it wasn't appropriate to do so because another scheduler thread resumed prior to the lock being acquired. This would result in incorrect behavior in the release build and an assertion in the debug build. See the following link for an example of the assertion being triggered: https://circleci.com/gh/ponylang/ponyc/3809?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link This commit fixes the issue by not suspending if the schduler count changed because another thread resumed.
dipinhora
pushed a commit
to dipinhora/ponyc
that referenced
this pull request
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, it was possible for a scheduler thread to
suspend even though it wasn't appropriate to do so because
another scheduler thread resumed prior to the lock being
acquired. This would result in incorrect behavior in the
release build and an assertion in the debug build.
See the following link for an example of the assertion being
triggered: https://circleci.com/gh/ponylang/ponyc/3809?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
This commit fixes the issue by not suspending if the schduler
count changed because another thread resumed.