Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove case functions #2542

Merged
merged 1 commit into from
Feb 10, 2018
Merged

Remove case functions #2542

merged 1 commit into from
Feb 10, 2018

Conversation

Praetonus
Copy link
Member

We're removing this feature as per RFC 51.

Closes #2540.

@Praetonus Praetonus force-pushed the remove-case-functions branch 3 times, most recently from 3fa9d8e to 9f85a4f Compare February 8, 2018 16:49
@Praetonus Praetonus changed the title Remove case functions implementation Remove case functions Feb 8, 2018
@Praetonus Praetonus added the changelog - changed Automatically add "Changed" CHANGELOG entry on merge label Feb 8, 2018
Remove case functions implementation
c6ea9b6 
We're removing this feature as per RFC 51.

Closes ponylang#2540.
@SeanTAllen SeanTAllen mentioned this pull request Feb 10, 2018
Closed
@SeanTAllen SeanTAllen merged commit 9f52985 into ponylang:master Feb 10, 2018
ponylang-main added a commit that referenced this pull request Feb 10, 2018
@ponylang-main
Update CHANGELOG for PR #2542 [skip ci]
82844b0
dipinhora pushed a commit to dipinhora/ponyc that referenced this pull request Jun 5, 2018
@ponylang-main @dipinhora
Update CHANGELOG for PR ponylang#2542 [skip ci]
cd16b72
@SeanTAllen SeanTAllen mentioned this pull request Mar 15, 2022
Closed
SeanTAllen added a commit that referenced this pull request Mar 19, 2022
@SeanTAllen
Fix parameter names not being checked
1a6a7dd 
In 2018, when we
[removed case functions](#2542) from
Pony, we also removed the checking to make sure that parameters names were
valid.

We've added checking of parameter names to make sure they match the naming
rules for parameters in Pony.

Fixes #4054
@SeanTAllen SeanTAllen mentioned this pull request Mar 19, 2022
Merged
SeanTAllen added a commit that referenced this pull request Mar 19, 2022
@SeanTAllen
Fix parameter names not being checked
a88c5e2 
In 2018, when we
[removed case functions](#2542) from
Pony, we also removed the checking to make sure that parameters names were
valid.

We've added checking of parameter names to make sure they match the naming
rules for parameters in Pony.

Fixes #4054
SeanTAllen added a commit that referenced this pull request Mar 19, 2022
@SeanTAllen
Fix parameter names not being checked (#4061)
38066ae 
In 2018, when we
[removed case functions](#2542) from
Pony, we also removed the checking to make sure that parameters names were
valid.

We've added checking of parameter names to make sure they match the naming
rules for parameters in Pony.

Fixes #4054
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jemc jemc jemc approved these changes

Assignees
No one assigned
Labels
changelog - changed Automatically add "Changed" CHANGELOG entry on merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Praetonus @jemc @SeanTAllen