-
-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Date to PosixDate #2436
Rename Date to PosixDate #2436
Conversation
Thanks @slayful. In the future, can you add more informative commit messages, perhaps stealing some reasoning from the issue and include a "Closes #XXXX"? Both those will help us greatly. Once this passes CI, I'm going to squash your commit, add a good commit message explaining the change and then close the corresponding issue. |
We need to update the changelog-tool before this can be merged and then .travis_script.sh will need to be updated as part of this PR to use the correct version of the changelog-tool. |
No problem, thanks for the update. :) |
@SeanTAllen is going to setup a linux bintray release of the changelog-tool so that we don't require building it from source in the ponyc CI. Once that is done and the travis config is updated this will require a rebase. |
@slayful can you rebase against master and force push to this branch? that should clear up the failure. |
f0412ae
to
f2c95ee
Compare
@SeanTAllen done - hopefully that will resolve any issues :) |
thanks @slayful |
#1902