Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Date to PosixDate #2436

Merged
merged 6 commits into from
Jan 26, 2018
Merged

Rename Date to PosixDate #2436

merged 6 commits into from
Jan 26, 2018

Conversation

slayful
Copy link
Contributor

@slayful slayful commented Dec 20, 2017

#1902

  • Date -> PosixDate.
  • If any of the creation arguments is negative set them to zero.
  • Tests for PosixDate.

@slayful slayful changed the title Gh 1902 clean Rename Date to PosixDate - clean PR Dec 20, 2017
@SeanTAllen SeanTAllen added the changelog - changed Automatically add "Changed" CHANGELOG entry on merge label Dec 21, 2017
@SeanTAllen SeanTAllen changed the title Rename Date to PosixDate - clean PR Rename Date to PosixDate Dec 21, 2017
@SeanTAllen
Copy link
Member

Thanks @slayful.

In the future, can you add more informative commit messages, perhaps stealing some reasoning from the issue and include a "Closes #XXXX"?

Both those will help us greatly.

Once this passes CI, I'm going to squash your commit, add a good commit message explaining the change and then close the corresponding issue.

@SeanTAllen
Copy link
Member

We need to update the changelog-tool before this can be merged and then .travis_script.sh will need to be updated as part of this PR to use the correct version of the changelog-tool.

@SeanTAllen
Copy link
Member

I'm leaving this for now. @Theodus lets discuss how to handle this at the next sync. This will come up from time to time and I think its a good chance to figure out how we will deal with. Sorry this will delay your PR @slayful.

@SeanTAllen SeanTAllen added do not merge This PR should not be merged at this time needs discussion during sync labels Dec 23, 2017
@slayful
Copy link
Contributor Author

slayful commented Dec 23, 2017

No problem, thanks for the update. :)

@Theodus
Copy link
Contributor

Theodus commented Jan 3, 2018

@SeanTAllen is going to setup a linux bintray release of the changelog-tool so that we don't require building it from source in the ponyc CI. Once that is done and the travis config is updated this will require a rebase.

@SeanTAllen
Copy link
Member

@slayful can you rebase against master and force push to this branch? that should clear up the failure.

@SeanTAllen SeanTAllen removed the do not merge This PR should not be merged at this time label Jan 6, 2018
@slayful
Copy link
Contributor Author

slayful commented Jan 26, 2018

@SeanTAllen done - hopefully that will resolve any issues :)

@SeanTAllen SeanTAllen merged commit 02e37b8 into ponylang:master Jan 26, 2018
ponylang-main added a commit that referenced this pull request Jan 26, 2018
@SeanTAllen
Copy link
Member

thanks @slayful

@slayful slayful deleted the GH-1902-clean branch January 29, 2018 15:51
@mfelsche mfelsche mentioned this pull request May 9, 2018
dipinhora pushed a commit to dipinhora/ponyc that referenced this pull request Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - changed Automatically add "Changed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants