Fix read past the end of a buffer in pool.c.
#2139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes `ponyint_pool_realloc_size`, which was reading past the end of the old buffer, which in some circumstances triggered a page fault.
jemc
reviewed
Aug 5, 2017
src/libponyrt/mem/pool.c
Outdated
| @@ -971,7 +971,7 @@ void* ponyint_pool_realloc_size(size_t old_size, size_t new_size, void* p) | |||
| new_p = pool_alloc_size(new_adj_size); | |||
| } | |||
|
|
|||
| memcpy(new_p, p, new_size); | |||
| memcpy(new_p, p, old_size); | |||
There was a problem hiding this comment.
Good catch!
But is it guaranteed that old_size < new_size here?
If not, wouldn't we want to take min(old_size, new_size) as the copy length?
Praetonus
approved these changes
Aug 5, 2017
|
I'm going to go out on a limb and say we should do a 0.17.1 for this. Thoughts? |
jemc
approved these changes
Aug 5, 2017
|
So far it looks like this function is only used in the compiler, not in the runtime. Is that correct, @kulibali and @Praetonus? If that's correct, I wouldn't necessarily consider this to be a release-triggering fix. |
|
It looks like it is only used in |
|
ok, no release then! good. i did want to go through that again today. |
chalcolith
added
the
changelog - fixed
|
Is this changelog-worthy? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes
ponyint_pool_realloc_size, which was reading past the end of the old buffer, which in some circumstances triggered a page fault.