Fix segfault in Array.trim_in_place #1999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the mirror update to Array.trim_in_place that was made previously in String. Relevant commit comment from String: Array.trim_in_place wasn't written to work correctly if you were to trim the array down to nothing and then append a size less than the "alloc" value that is left. This combination could result in incorrect handling for arrays that end up with a size of 0. This is because, a new pointer was created, but we retained incorrect alloc info. This wouldn't cause an error so long as when you used the array for something like an append, reserve allocated new memory. However, if the appended value was less than the perceived alloc size, no additional memory would be added and kaboom. see 381b281
SeanTAllen
added
the
changelog - fixed
ponylang-main
added a commit
that referenced
this pull request
Jul 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the mirror update to Array.trim_in_place that was made
previously in String. Relevant commit comment from String:
Array.trim_in_place wasn't written to work correctly if you were
to trim the array down to nothing and then append a size less than the
"alloc" value that is left. This combination could result in incorrect
handling for arrays that end up with a size of 0.
This is because, a new pointer was created, but we retained incorrect
alloc info. This wouldn't cause an error so long as when you used the
array for something like an append, reserve allocated new memory.
However, if the appended value was less than the perceived alloc size,
no additional memory would be added and kaboom.
see 381b281