Change machine word constructors to have no default argument. #1938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jemc
added
changelog - changed
This is meant to prevent confusion with respect to other primitives
whose value can be compared using `is ${PrimitiveName}`. Machine words
are special primitives that can have multiple values, and comparing
with `is ${MachineWord}` is currently equivalent to comparing to zero.
Incidentally, fixing this also alerts us to the bug in #1920.
We should hold off on merging this PR until after #1927 is merged.
jemc
force-pushed
the
change/machine-word-constructor-no-default-arg
branch
from
f8cb52f
to
6a57bfb
Compare
|
Rebased after merging #1927. This is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to prevent confusion/surprise with respect to other primitives
whose value can be compared using
is ${PrimitiveName}. Machine wordsare special primitives that can have multiple values, and comparing
with
is ${MachineWord}is currently equivalent to comparing to zero.Incidentally, fixing this also alerts us to the bug in #1920.
We should hold off on merging this PR until after #1927 is merged.