Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix annotation-related compiler assertion failure (issue #1751) #1757

Merged
merged 1 commit into from
Mar 27, 2017

Conversation

jemc
Copy link
Member

@jemc jemc commented Mar 26, 2017

This PR fixes #1751, a compiler assertion error related to the efficient storage system for AST annotations and types, introduced in #1649.

This PR also changes the system somewhat, to rely on the token type that annotations use (TK_BACKSLASH), instead of using the AST_ANNOTATED flag.

Fixes #1751, a compiler assertion error related to this system.
@jemc jemc force-pushed the fix/annotation-type-assert branch from c28dd31 to 55b0f32 Compare March 26, 2017 21:43
@jemc jemc added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label Mar 27, 2017
@jemc jemc changed the title Fix: efficient storage of AST annotation/type from #1649. Fix annotation-related compiler assertion error. Mar 27, 2017
@jemc jemc changed the title Fix annotation-related compiler assertion error. Fix annotation-related compiler assertion error (issue #1751) Mar 27, 2017
@jemc jemc changed the title Fix annotation-related compiler assertion error (issue #1751) Fix annotation-related compiler assertion (issue #1751) Mar 27, 2017
@jemc jemc changed the title Fix annotation-related compiler assertion (issue #1751) Fix annotation-related compiler assertion failure (issue #1751) Mar 27, 2017
@Praetonus Praetonus merged commit 29a9bb4 into master Mar 27, 2017
ponylang-main added a commit that referenced this pull request Mar 27, 2017
@jemc jemc deleted the fix/annotation-type-assert branch March 27, 2017 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assertion failure with annotations
2 participants