Allow Ponytest to exclude or include tests by name #1717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanTAllen
added
changelog - added
|
@SeanTAllen I'd prefer option 1. |
jemc
reviewed
Mar 18, 2017
packages/ponytest/pony_test.pony
Outdated
| @@ -376,6 +390,8 @@ actor PonyTest | |||
| _no_prog = true | |||
| elseif arg == "--list" then | |||
| _list_only = true | |||
| elseif arg.compare_sub("--exclude=", 10) is Equal then | |||
| _filter = arg.substring(9) | |||
There was a problem hiding this comment.
I think this 9 needs to be a 10 to cover the whole substring.
SeanTAllen
force-pushed
the
ponytest-exclude-flag
branch
from
88d1e1a
to
076e47a
Compare
|
That's my preferred approach as well @jemc. I'm going to leave this as is until either @Praetonus or @sylvanc weighs in. If we get another core vote for 1, I'll move forward with that approach. |
|
Option 1 is good. |
SeanTAllen
force-pushed
the
ponytest-exclude-flag
branch
from
076e47a
to
51c63b3
Compare
SeanTAllen
changed the title
|
option 1 it is. updated. |
SeanTAllen
removed
changelog - added
|
Since you've edited the changelog, you may see conflicts because we've now cut a 0.11.4 release. 😅 |
SeanTAllen
force-pushed
the
ponytest-exclude-flag
branch
from
51c63b3
to
5850e0e
Compare
Adds --exclude command line option that can be used to exclude any tests whose name starts with the given prefix. Renames existing --filter command line option to --only to provide better symmetry with --exclude.
SeanTAllen
force-pushed
the
ponytest-exclude-flag
branch
from
5850e0e
to
6736f7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds --exclude command line option that can be used to
exclude any tests whose name starts with the given prefix.
Renames existing --filter command line option to --only to provide
better symmetry with --exclude.