Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the check for union types on match error #1630

Merged
merged 2 commits into from
Mar 4, 2017
Merged

Remove the check for union types on match error #1630

merged 2 commits into from
Mar 4, 2017

Commits on Mar 3, 2017

  1. Remove the check for union types on match error 

    A nice attempt to produce a much friendlier error message when a union
type pattern is involved and a match expression doesn't type check is
sadly removed in this commit.

Unfortunately, it assumed union types would be composed of nominal types
(not true), and that the problem with the match was a union type with
varying capabilities (this is actually allowed).

A nicer error message would indeed be useful here. The right approach
would be to emit errors in `matchtype.c` when they are needed, i.e. on
DENY.
    @sylvanc
    sylvanc committed Mar 3, 2017
    Configuration menu
    Copy the full SHA
    55d1bcf View commit details
    Browse the repository at this point in the history

  2. remove the associated test

    @sylvanc
    sylvanc committed Mar 3, 2017
    Configuration menu
    Copy the full SHA
    33d8ee5 View commit details
    Browse the repository at this point in the history