Add assert_no_error test condition to PonyTest #1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praetonus
force-pushed
the
ponytest-assert-noerror
branch
from
d9bc06a
to
2cab76a
Compare
|
The name seems kind of odd to me. To me an assert involves a comparison which this doesn't do. |
|
Name seems straightforward to me, especially in the context of having an Are there any other names to propose? |
|
Nope. I find assert_error odd as well. It matches up with what's there. |
|
I'm good with merging this. |
|
Shouldn't there be a changelog label? |
jemc
added
the
changelog - added
ponylang-main
added a commit
that referenced
this pull request
Feb 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was surprised when not finding this function in the package. I don't think this requires an RFC since it looks like an oversight.