Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes NetAddress comparable #1569

Merged
merged 1 commit into from
Feb 15, 2017
Merged

Makes NetAddress comparable #1569

merged 1 commit into from
Feb 15, 2017

Commits on Feb 9, 2017

  1. Makes NetAddress comparable

    Provides two types of equality.
    
    1: "basic equality"
    
    Compares all the fields of NetAddress to see if they are equal. This
    is the comparison if we use `==` or `eq`.
    
    2: "address equality"
    
    Compares based on the ip address portion of NetAddress. Does not
    take port, family, length or scope into account. We are using
    "address equality" at Sendence to compare, "is this IP for a local
    or remote address" which is in turn used to decide whether to turn
    on TCP_NODELAY (on Linux, using TCP_NODELAY on local addresses has
    a negative impact on our performance/stability. Using it on
    remote addresses helps our performance/stability).
    SeanTAllen committed Feb 9, 2017
    Configuration menu
    Copy the full SHA
    4cf72fa View commit details
    Browse the repository at this point in the history