Skip to content
This repository has been archived by the owner on Jul 10, 2023. It is now read-only.

ListFolder if the folder is not found should return a 404 #26

Closed
michielbdejong opened this issue Sep 24, 2021 · 3 comments
Closed

ListFolder if the folder is not found should return a 404 #26

michielbdejong opened this issue Sep 24, 2021 · 3 comments
Assignees
@Triantafullenia-Doumani

Comments

@michielbdejong
Copy link
Member

There is a check for $this->filesystem->listContents($path) returning false, but it seems that if a folder really doesn't exist, it returns [] instead?
michielbdejong added a commit that referenced this issue Sep 24, 2021
@michielbdejong
Mention #26
8c144e1
@michielbdejong
Copy link
Member Author

See also cs3org/reva#2105 about what the desired behaviour is at the Reva level.

michielbdejong added a commit that referenced this issue Sep 28, 2021
@michielbdejong
Failing unit test for #26
28225a3
@michielbdejong michielbdejong changed the title What happens with listFolder if the folder is not found? ListFolder if the folder is not found should return a 404 Sep 28, 2021
@michielbdejong
Copy link
Member Author

@Triantafullenia-Doumani can you have a look at this in the 'fix-26' branch?

@michielbdejong
Copy link
Member Author

This was fixed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Triantafullenia-Doumani Triantafullenia-Doumani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michielbdejong @Triantafullenia-Doumani