Contract source filter #1373
Merged
Contract source filter #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: add logs * chore: changeset --------- Co-authored-by: typedarray <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* chore: improve pg error handling for tests * chore: changeset * chore: use error prop --------- Co-authored-by: typedarray <[email protected]>
* typo: merge abis url * Update contracts-and-networks.mdx --------- Co-authored-by: Kevin <[email protected]>
* fix: raw sql sets fast path flag to false * test --------- Co-authored-by: typedarray <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
feat: future endBlock
chore: version packages
kyscott18
reviewed
Dec 31, 2024
| source.filter, | ||
| ).reduce( | ||
| (acc, cur) => { | ||
| if (acc.includes(cur) === false) { |
There was a problem hiding this comment.
Not sure if this .includes() works how you expect on objects
| topic2: null, | ||
| topic3: null, | ||
| }, | ||
| ]; | ||
|
|
||
| if (source.filter !== undefined) { |
There was a problem hiding this comment.
I'm finding this code block a little hard to follow. I think you have it right: multiple filters in the config should result to multiple sources. Might be helpful to try to limit the use of .reduce
| export type GetEventFilter< | ||
| abi extends Abi, | ||
| contract, | ||
| /// | ||
| safeEventNames extends string = SafeEventNames<abi>, | ||
| > = contract extends { | ||
| filter: { | ||
| event: infer event extends readonly string[] | string; | ||
| event: infer event extends string; |
There was a problem hiding this comment.
Need to add a branch for array of filters
| }); | ||
| }); | ||
|
|
||
| test("event filter with event and args", () => { | ||
| test("event filters with event only filter", () => { |
kyscott18
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1372. Added a support for more flexible contract source filters in build. Currently, I am assuming the type of the filter as defined in #1372. If we land on this design for an api, the next step would be dealing with
GetEventFiltertype in the config.