UI fixes #1169
Merged
UI fixes #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyscott18
reviewed
Oct 16, 2024
| @@ -19,7 +19,7 @@ export type UiState = { | |||
|
|
|||
| export const buildUiState = (): UiState => { | |||
| return { | |||
| port: 0, | |||
| port: 42069, | |||
There was a problem hiding this comment.
What if port is not this
There was a problem hiding this comment.
It gets updated in service.ts on the first render. The default here should not matter. Happy to change back to 0 to make that more clear actually.
There was a problem hiding this comment.
Ah yeah maybe that would be helpful, or a comment
There was a problem hiding this comment.
Just tested - there actually can be a few frames where it renders the default (before server/index.ts finds free port) so I think it's better to use the same default here as in common.options.
kyscott18
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0after a hot reload