Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing callbacks #57

Closed
wants to merge 19 commits into from
Closed

Fix missing callbacks #57

wants to merge 19 commits into from

Commits on Nov 29, 2023

  1. Adding the APIs

    @tatianacv
    tatianacv committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    440e641 View commit details
    Browse the repository at this point in the history

  2. Adding other test

    @tatianacv
    tatianacv committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    a8e2ddc View commit details
    Browse the repository at this point in the history

  3. Adding documentation

    @tatianacv
    tatianacv committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    ebc3b34 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. Getting the callbacks in the CG

    @tatianacv
    tatianacv committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    ae7078c View commit details
    Browse the repository at this point in the history

  2. Adding spotless

    @tatianacv
    tatianacv committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    db9f985 View commit details
    Browse the repository at this point in the history

  3. Adding experimental

    @tatianacv
    tatianacv committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    7b6717b View commit details
    Browse the repository at this point in the history

  4. Addressing requested changes

    @tatianacv
    tatianacv committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    7131070 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into 92-missing_callbacks

    @khatchad
    khatchad authored Nov 30, 2023
    Configuration menu
    Copy the full SHA
    72610a6 View commit details
    Browse the repository at this point in the history

  6. Add correct params, but test will fail

    @tatianacv
    tatianacv committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    5e29516 View commit details
    Browse the repository at this point in the history

  7. Let's focus on one test for now.

    @khatchad
    khatchad committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    95df2eb View commit details
    Browse the repository at this point in the history

  8. Remove comment. 

    Only having it in the CG is not going to help us.
    @khatchad
    khatchad committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    3ec179a View commit details
    Browse the repository at this point in the history

  9. Lose a URL. 

    I don't think we need both.
    @khatchad
    khatchad committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    e5d5a3a View commit details
    Browse the repository at this point in the history

  10. Format.

    @khatchad
    khatchad committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    6b0af76 View commit details
    Browse the repository at this point in the history

  11. Change tests. 

    One direct and one indirect.
    @khatchad
    khatchad committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    6bcb8ae View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Merge branch 'master' into 92-missing_callbacks

    @khatchad
    khatchad committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    761b231 View commit details
    Browse the repository at this point in the history

  2. The value number here is actually 2 not 1. 

    We know this now as a result of wala#109.
    @khatchad
    khatchad committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    b0c13ec View commit details
    Browse the repository at this point in the history

  3. Also update the comment.

    @khatchad
    khatchad committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    873c7f0 View commit details
    Browse the repository at this point in the history

  4. Took a crack at sending the argument.

    @khatchad
    khatchad committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    82969d6 View commit details
    Browse the repository at this point in the history

  5. Yet another crack.

    @khatchad
    khatchad committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    835548c View commit details
    Browse the repository at this point in the history