Fork aware offchain Database #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seunlanlege
approved these changes
Apr 25, 2024
seunlanlege
added a commit
that referenced
this pull request
May 8, 2024
Co-authored-by: Seun Lanlege <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the merkle mountain range overlay tree to a separate pallet that stores nodes in the offchain db in a fork-aware manner (indexing_prefix + pos + parent_hash => node). This avoids corrupting the tree whenever forks happen and the chain re-orgs. This didn't used to be an issue until async-backing was introduced.
This new pallet is paired with an offchain task that "canonicalizes" (indexing_prefix + pos => node) the mmr nodes in the offchaindb by removing the parent hash part of the key when finality notifications are observed. This subsystem has been integration tested with simnode.