Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dep conflict #196

Merged
merged 2 commits into from
May 3, 2023
Merged

fix: dep conflict #196

merged 2 commits into from
May 3, 2023

Conversation

mjbradford89
Copy link
Contributor

Ran into this issue with vcrpy kevin1024/vcrpy#688 that is also happening on develop https://gitlab.polyswarm.io/externalci/polyswarm-api/-/jobs/237116.

__________________ ERROR collecting test/client_scan_test.py ___________________
/usr/local/lib/python3.7/site-packages/vcr/patch.py:40: in <module>
    _VerifiedHTTPSConnection = cpool.VerifiedHTTPSConnection
E   AttributeError: module 'urllib3.connectionpool' has no attribute 'VerifiedHTTPSConnection'

The easiest fix seems like not using the latest requests package, which uses the newer version of urllib. We use requests in our api, but vcrpy is only used for testing purposes. So I created a separate requirements file. That way we can still use the latest requests package without running into the testing issue.

Copy link
Contributor

@mrsarm mrsarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice trick!

Still we should subscribe to the issue in vcr, and once fixed in their side just upgrade to the last version, but in the meantime we need this.

@mjbradford89 mjbradford89 merged commit aaee0e2 into develop May 3, 2023
@mjbradford89 mjbradford89 deleted the fix/dep_conflict branch May 3, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants