Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ability to cancel running Async actions #321

Merged
merged 2 commits into from
Jun 8, 2020
Merged

Added ability to cancel running Async actions #321

merged 2 commits into from
Jun 8, 2020

Conversation

aidangilmore
Copy link
Contributor

@aidangilmore aidangilmore commented Feb 16, 2020 •
edited
Loading

I thought this may come in handy.

@aidangilmore aidangilmore changed the title WIP: Added ability to cancel running Async actions Added ability to cancel running Async actions May 1, 2020
@sorki
Copy link

sorki commented Jun 8, 2020

I was looking for this the other day, thanks!

@googleson78
Copy link
Member

Is there anything dangerous about this or other reasons we shouldn't merge it? @KingoftheHomeless

@KingoftheHomeless
Copy link
Collaborator

Huh. Yeah, I saw withAsync and was dubious towards its safety, and thought to look into it later when I had time. Now I see the author figured out that it was unsafe, and removed it. This is good to merge.

KingoftheHomeless
KingoftheHomeless approved these changes Jun 8, 2020
View reviewed changes
Copy link
Collaborator

@KingoftheHomeless KingoftheHomeless left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can look into extending this with a safe variant of withAsync later; the current pull request is a straight-forward improvement with no downsides.

@KingoftheHomeless KingoftheHomeless merged commit ded35ce into polysemy-research:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KingoftheHomeless KingoftheHomeless KingoftheHomeless approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aidangilmore @sorki @googleson78 @KingoftheHomeless