Adapt to NDK r25 #1103
Merged
Adapt to NDK r25 #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 8, 2022 15:19
GhenadiePusca
pushed a commit
that referenced
this pull request
Aug 17, 2022
* Add first oxi version to core (broken) * Wire up oxi * Clean up and remove db from git * Add rdf.db to ignore * Map Rdf error to coreFailure * Wire up core - android endpoints * Link libc++_shared.so * Fix libc++ shared file path * Add api android * Fix cargo lock and lint kotlin * Add path as variable to get the path with permissions * Wire android api to api * Remove tests * Remove unused import * Add oxi licenses * Forgot this stupid empty line * Add function to init store and make an env constant * Improve safety and error mapping * Check queries before executing them * Fix missing parenthesis (#1097) * Fix issues with imoporting store after changes to polyOut * Poly out core - without integration (#1094) * Fis import bug * Change queryResult to json string * Fix test for string changes * Core to Native communication (#1101) # ✍️ Description Currently the Native part can make calls to the Rust Core, but the other way around is not yet supported. This PR implements a mechanism that allows the Rust Core to make calls to the Native part. * Adapt to NDK r25 (#1103) * Adapt to NDK r25 * Add back the comment * PROD4POD-1797 - Fix button for wider screens * Make return type string also in api * Add some weird commata to please the linter * Get my formatter going again and fix those linting problems * MORE LINTING * Use oxigraph node version for jest testing (duuhh) * Fix another import problem by just adding commonjs and node-resolve - works every time * Fix iOS update notification tests # ✍️ Description The iOS notification tests fail for me quite consistently locally, the same notification shows up twice even though it was previously closed. Adding a `sleep` after the `tap` of the close button seems to fix it. ### 🏗️ Fixes (#jira-issue-number or link) There's no Jira issue. * Revert "Fix another import problem by just adding commonjs and node-resolve - works every time" This reverts commit 3d35632. * Mock store instead of using oxigraph * Add user session timeout (#1105) * Add onboarding tests # ✍️ Description Adding some integration tests that ensure the onboarding screen shows up on both Android and iOS. ### 🏗️ Fixes (PROD4POD-1196) Co-authored-by: Ghenadie Vasiliev-Pusca <[email protected]> Co-authored-by: Juan Julián Merelo Guervós <[email protected]> * Enable bindgen args * Eliminate copying the test feature to the device # ✍️ Description At the moment, every time we deploy the tests, the build process will copy over the feature named "test" to the device. Now that we're always bundling - but not displaying - it, we can just add a preference for forcing it to show up, and execute the tests in it that way, so we don't need this logic anymore. It's sometimes causing trouble when trying to run the tests - happened to me again just now - and it's not worth debugging if we don't need it. Related to PROD4POD-1721. * feat: prod4pod-1829 - add polypoly membership feature folder structure (#1109) * generated folder structure from CLI * updated package name * included in build * iOS user session (#1108) * user session * Cleanup for review * Integrate in platforms * Add logging for the error * Small adjustments * cargo fmt fixes * Cargo clippy fixes * JniApi singleton updates * ktlint fix * core interface fixes * Fix formatting error * Avoid force unwrapping * Add java/c api * Fix c interface method name * Remove obsolete ktlint disable * Fix naming * Add core api * Build timeout UI * Add Strings * Add user session expire * Cleanup * Save preferences when app becomes inactive * iOS polish * Swiftlint fixes * Cleanup spaces/uneccesary code * Make use of guard let * Fix linter issues for latest Rust version * Point ndk path straight to 25 ndk * Fix lint * Maybe now? * Generate new lock * Fix missing bracket * Get rid of double declaration * Improve yoda linting case failure * Hopefully fix this now * Make it messagepackserialze Co-authored-by: Ghenadie Vasiliev-Pusca <[email protected]> Co-authored-by: Tim Palade <[email protected]> Co-authored-by: mteresa-jimenez <[email protected]> Co-authored-by: Felix H. Dahlke <[email protected]> Co-authored-by: Juan Julián Merelo Guervós <[email protected]> Co-authored-by: Georgiana Piscoi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Description
GH environment released NDK r25 support -> https://github.com/actions/virtual-environments/releases.
What has been done:
ANDROID_NDK_LATEST_HOMEvariable. GH updated to point to standard paths, such asNDK_Home-> [macOS] Add ndk-related environment variables actions/runner-images#5984