handle error off of update by id on process errand (#16)

* handle error off of update by id on process errand * Update errands-routes.go Co-authored-by: Michael Moghaddam <[email protected]> Co-authored-by: Michael Moghaddam <[email protected]>
polygon-io · Nov 3, 2021 · 0775674 · 0775674
1 parent 3c5fbcd
commit 0775674
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/errands-routes.go b/errands-routes.go
@@ -223,8 +223,7 @@ func (s *ErrandsServer) processErrand(c *gin.Context) {
 
 	procErrand = errands[0]
 
-	// We are processing this errand. This won't ever return error
-	updatedErrand, _ := s.UpdateErrandByID(procErrand.ID, func(errand *schemas.Errand) error {
+	updatedErrand, err := s.UpdateErrandByID(procErrand.ID, func(errand *schemas.Errand) error {
 		errand.Started = utils.GetTimestamp()
 		errand.Attempts++
 		errand.Status = schemas.StatusActive
@@ -234,6 +233,15 @@ func (s *ErrandsServer) processErrand(c *gin.Context) {
 		return nil
 	})
 
+	if err != nil {
+		log.WithError(err).Warn("potentially no job found")
+
+		c.JSON(http.StatusNotFound, gin.H{
+			"message": "No jobs",
+		})
+		return
+	}
+
 	s.AddNotification("processing", updatedErrand)
 	c.JSON(http.StatusOK, gin.H{
 		"status":  "OK",