Address issue 227 by adopting XDG config convention #228
Conversation
By default, that's `~/.config/polylith/config.edn` but the `XDG_CONFIG_HOME` environment variable can override the `~/.config` part of that path.
Copy the file. Read the old config, prepend a migration comment, and write it back.
This reverts a potentially breaking change where I calculated `home-dir` from the `HOME` environment variable. Now only the config file location uses `HOME` and that's because the XDG specification explicitly relies on environment variables.
|
Apparently, the Circle CI updates were acceptable. |
By default, that's `~/.config/polylith/config.edn` but the `XDG_CONFIG_HOME` environment variable can override the `~/.config` part of that path.
Copy the file. Read the old config, prepend a migration comment, and write it back.
This reverts a potentially breaking change where I calculated `home-dir` from the `HOME` environment variable. Now only the config file location uses `HOME` and that's because the XDG specification explicitly relies on environment variables.
There was a problem hiding this comment.
Hi Sean!
This looks great to me. I have just tested it on my machine, which is not an XGD system, and it seems to work as before. I will approve this if you update polylith.clj.core.version.interface with the correct issue and date, e.g.:
(def revision "alpha-issue227-01")
(def date "2022-05-29")
I need to update the gitbook documentation also, branch "Release 0.2.15" (that's the downside of letting the documentation live in a separate repo).
|
Updates made. |
This addresses #227 by:
config.ednlocation to the XDG location (default~/.config/polylith/config.ednbut overridable via theXDG_CONFIG_HOMEenvironment variable).~/.polylith/config.ednto the new location, adding a comment in the old file so any projects still using olderpolyversions can still read it.