feat: pluggable test runner #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkrausse
reviewed
Mar 25, 2022
components/kaocha-test-runner-example/src/polylith/clj/core/kaocha_test_runner_example/core.clj
Outdated
Show resolved
Hide resolved
- extract pluggable test runner impl - extract some common message ops - leave only the responsibility of organizing the high level process
furkan3ayraktar
added
core
components/clojure-test-test-runner/src/polylith/clj/core/clojure_test_test_runner/core.clj
Show resolved
Hide resolved
components/common/src/polylith/clj/core/common/class_loader.clj
Outdated
Show resolved
Hide resolved
components/workspace-clj/src/polylith/clj/core/workspace_clj/project_settings.clj
Show resolved
Hide resolved
This was referenced Apr 7, 2022
Was unable to reproduce the issue
|
Thank you for working on this, I've just started porting our 150k line codebase over to polylith and management has been breathing down my neck about code coverage stats 😓 . |
Glad someone else finds this useful :) I haven't yet set up coverage on our end with this, so if you end up with code you can share that would be great! |
tengstrand
reviewed
Apr 29, 2022
| @@ -31,14 +30,14 @@ | |||
| {:keys [top-namespace interface-ns color-mode]} settings | |||
| suffixed-top-ns (common/suffix-ns-with-dot top-namespace) | |||
| interfaces (interfaces/calculate components) | |||
| interface-names (apply sorted-set (filter identity (mapv :name interfaces))) | |||
| interface-names (into (sorted-set) (keep :name) interfaces) | |||
There was a problem hiding this comment.
Awesome that you find and improve things like this!
tengstrand
approved these changes
Apr 29, 2022
@SavageMessiah in case you use kaocha, I managed to get cloverage working through polylith-kaocha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the option to supply a custom test runner.
A previous version of this PR contained an example implementation using kaocha, I will recreate that outside of this repo and link it.
Todo:
tests-present?polylith/components/workspace/src/polylith/clj/core/workspace/project.clj
Lines 40 to 50 in e874e80