Fix for build failure due to change in TypeId hash size (64 to 128 bits) in Rust 1.72.0.

[timmyjose]

Changes (due to Rust 1.72 having changed TypeId from 64 to 128 bits):

• updated v8 to 0.75.1 (latest) for the gateway crate.

Notes: (full notes on Linear):

• Rust 1.72 has changed the size of TypeId hash from 64 to 128 bits (https://github.com/rust-lang/rust/releases/tag/1.72.0). Relevant issue here - Increase TypeId's hash from 64 bits to 128 bits. rust-lang/compiler-team#608.
• This caused build failure due to the old version of v8 (0.62.2) not having the updates in the assert statement as shown below:

v0.62.2:

const _: () = {
  assert!(size_of::<TypeId>() == size_of::<u64>());
  assert!(align_of::<TypeId>() == align_of::<u64>());
};

latest (v0.75.1):

const _: () = {
  assert!(
    size_of::<TypeId>() == size_of::<u64>()
      || size_of::<TypeId>() == size_of::<u128>()
  );
  assert!(
    align_of::<TypeId>() == align_of::<u64>()
      || align_of::<TypeId>() == align_of::<u128>()
  );
};

[linear]

ENG-1017 `cargo build` on `Polybase-rust` fails with rustc 1.72.0 due to changes in `TypeId`.

The v8 crate dependency (for the gateway crate) uses v0-62.2 which has the following check in isolate.rs:

assert!(size_of::<TypeId>() == size_of::<u64>());

which fails in Rust 1.72 due to TypeId having been changed to 128bits:

Release notes: https://github.com/rust-lang/rust/releases/tag/1.72.0

Relevant issue: rust-lang/compiler-team#608

This is causing a failure in CI as well (the other jobs passed due to caching, I presume):

 #27 58.37 error[E0080]: evaluation of constant value failed
#27 58.37     --> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/v8-0.62.2/src/isolate.rs:1715:3
#27 58.37      |
#27 58.37 1715 |   assert!(size_of::<TypeId>() == size_of::<u64>());
#27 58.37      |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the evaluated program panicked at 'assertion failed: size_of::<TypeId>() == size_of::<u64>()', /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/v8-0.62.2/src/isolate.rs:1715:3
#27 58.37      |
#27 58.37      = note: this error originates in the macro `assert` (in Nightly builds, run with -Z macro-backtrace for more info)
#27 58.37 
#27 58.42 For more information about this error, try `rustc --explain E0080`.
#27 58.43 error: could not compile `v8` (lib) due to previous error
#27 58.43 warning: build failed, waiting for other jobs to finish...
#27 81.40 thread 'main' panicked at 'Exited with status code: 101', /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/cargo-chef-0.1.62/src/recipe.rs:204:27
#27 81.40 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
#27 ERROR: process "/bin/sh -c cargo chef cook --recipe-path /recipe.json $(if [ \"$RELEASE\" = \"1\" ]; then echo \"--release\"; fi)" did not complete successfully: exit code: 101
------
 > [builder  2/13] RUN --mount=type=cache,target=/usr/local/cargo/registry     cargo chef cook --recipe-path /recipe.json $(if [ "1" = "1" ]; then echo "--release"; fi):
#27 58.37 1715 |   assert!(size_of::<TypeId>() == size_of::<u64>());
#27 58.37      |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the evaluated program panicked at 'assertion failed: size_of::<TypeId>() == size_of::<u64>()', /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/v8-0.62.2/src/isolate.rs:1715:3
#27 58.37      |
#27 58.37      = note: this error originates in the macro `assert` (in Nightly builds, run with -Z macro-backtrace for more info)
#27 58.37 
#27 58.42 For more information about this error, try `rustc --explain E0080`.
#27 58.43 error: could not compile `v8` (lib) due to previous error
#27 58.43 warning: build failed, waiting for other jobs to finish...
#27 81.40 thread 'main' panicked at 'Exited with status code: 101', /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/cargo-chef-0.1.62/src/recipe.rs:204:27
#27 81.40 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

[timmyjose]

Sanity checks done:

• Ran the e2e tests locally
• Ran some manual operations locally (create collections and collection records).

[mateuszmlc]

We should also change the Rust version in the Dockerfile either to 1.72 or back to just 1 (and let docker pick latest minor) https://github.com/polybase/polybase-rust/blob/main/docker/Dockerfile#L2

[timmyjose]

We should also change the Rust version in the Dockerfile either to 1.72 or back to just 1 (and let docker pick latest minor) https://github.com/polybase/polybase-rust/blob/main/docker/Dockerfile#L2

Good catch! I think changing that to "1" makes sense - let Docker pick up the latest minor version.

[calummoore]

Nice work team!