Use the right encoder #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## [1.1.8](polonel/trudesk@v1.1.7...v1.1.8) (2021-07-25) ### Bug Fixes * **tickets:** creation has no response [polonel#423](polonel#423) by alsemany ([dcfde5f](polonel@dcfde5f))
The dbPassword is being added as a part of the URI and hence should use encodeURI. encodeURIComponent is right if the password was being sent as a query parameter. This fixes an issue when using Azure Cosmos DB where the password is a base64 encoded string, which contains the '=' character. This character should not be encoded as part of the URI.
polonel
added a commit
that referenced
this pull request
Sep 19, 2021
## [1.1.9](v1.1.8...v1.1.9) (2021-09-19) ### Bug Fixes * **about:** links in about page ([2425d7e](2425d7e)) * **db:** EncodeURI PR [#437](#437) by [@vijaye-statsig](https://github.com/vijaye-statsig) ([bb9ea9b](bb9ea9b)) * **install:** default setting for skipping elastic search ([88df9b0](88df9b0)) * **install:** typo in elastic search preventing connection ([3678292](3678292)) * **mailcheck:** added option for less secure certs in mailcheck ([0e6fd69](0e6fd69)), closes [PR#434](https://github.com/PR/issues/434)
|
🎉 This PR is included in version 1.1.9 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dbPassword is being added as a part of the URI and hence should use encodeURI. encodeURIComponent is right if the password was being sent as a query parameter.
This fixes an issue when using Azure Cosmos DB where the password is a base64 encoded string, which contains the '=' character. This character should not be encoded as part of the URI.