Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annoying character limit for Chinese characters #116

Closed
1 of 2 tasks
XcrossD opened this issue Nov 30, 2018 · 2 comments
Closed
1 of 2 tasks

Annoying character limit for Chinese characters #116

XcrossD opened this issue Nov 30, 2018 · 2 comments

Comments

@XcrossD
Copy link

XcrossD commented Nov 30, 2018

Is this a BUG REPORT or FEATURE REQUEST?:

  • BUG
  • FEATURE

What happened:
When typing in a character limited field, the string cannot be accepted due to character limit even though its perfectly fine in Chinese.

What did you expect to happen:
Maybe shorten the restriction for Chinese language or add a setting option to adjust character limit.

How to reproduce it (as minimally and precisely as possible):
網路斷線 (No Internet) cannot be accepted.
我的電腦網路斷線一整天 <- Only strings with over 10 characters are valid, but this is impractical for the Chinese language.

Environment:
i18n test site

@polonel
Copy link
Owner

polonel commented Nov 30, 2018

Thanks for pointing this out. I'll implement a setting to customize this.

@polonel polonel closed this as completed Jan 6, 2019
polonel added a commit that referenced this issue Jan 9, 2019
## [1.0.5](v1.0.4...v1.0.5) (2019-01-09)

### Bug Fixes

* **api:** tickets [#124](#124) - unable to update ticket status ([ab614a4](ab614a4))
* **backup:** crash on restore ([a613612](a613612))
* **backup:** restore directory fails to create ([d68a045](d68a045))
* **backup:** restore sending error response to soon ([605c8d8](605c8d8))
* **mailcheck:** event leak ([23eaab3](23eaab3))
* **nav:** disappearing dashboard button ([32a4e87](32a4e87))
* **overdue:** overdue card showing incorrect tickets ([72e2584](72e2584))
* **tags:** tags with min2 were not creating ([9a22364](9a22364))
* **ticket:** fix [#116](#116) - ability to configure character limit on tickets ([88ae488](88ae488))
@polonel
Copy link
Owner

polonel commented Jan 9, 2019

🎉 This issue has been resolved in version 1.0.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

polonel added a commit that referenced this issue Jan 9, 2019
## [1.0.5](v1.0.4...v1.0.5) (2019-01-09)

### Bug Fixes

* **api:** tickets [#124](#124) - unable to update ticket status ([ab614a4](ab614a4))
* **backup:** crash on restore ([a613612](a613612))
* **backup:** restore directory fails to create ([d68a045](d68a045))
* **backup:** restore sending error response to soon ([605c8d8](605c8d8))
* **mailcheck:** event leak ([23eaab3](23eaab3))
* **nav:** disappearing dashboard button ([32a4e87](32a4e87))
* **overdue:** overdue card showing incorrect tickets ([72e2584](72e2584))
* **tags:** tags with min2 were not creating ([9a22364](9a22364))
* **ticket:** fix [#116](#116) - ability to configure character limit on tickets ([88ae488](88ae488))
polonel added a commit that referenced this issue Jan 9, 2019
## [1.0.5](v1.0.4...v1.0.5) (2019-01-09)

### Bug Fixes

* **api:** tickets [#124](#124) - unable to update ticket status ([ab614a4](ab614a4))
* **backup:** crash on restore ([a613612](a613612))
* **backup:** restore directory fails to create ([d68a045](d68a045))
* **backup:** restore sending error response to soon ([605c8d8](605c8d8))
* **mailcheck:** event leak ([23eaab3](23eaab3))
* **nav:** disappearing dashboard button ([32a4e87](32a4e87))
* **overdue:** overdue card showing incorrect tickets ([72e2584](72e2584))
* **tags:** tags with min2 were not creating ([9a22364](9a22364))
* **ticket:** fix [#116](#116) - ability to configure character limit on tickets ([88ae488](88ae488))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants