Fixes Qiskit#7078: Put checks in SetPhase, ShiftPhase and SetPhase. R…

…emove check from Delay.

qiskit/pulse/instructions/delay.py

@@ -14,8 +14,7 @@
 from typing import Optional, Union, Tuple
 
 from qiskit.circuit import ParameterExpression
-from qiskit.pulse.channels import Channel, ClassicalIOChannel
-from qiskit.pulse.exceptions import PulseError
+from qiskit.pulse.channels import Channel
 from qiskit.pulse.instructions.instruction import Instruction
 
 
@@ -54,12 +53,6 @@ def __init__(
             PulseError: If `channel` cannot be delayed because it is a classical IO channel.
         """
         super().__init__(operands=(duration, channel), name=name)
-        if isinstance(channel, ClassicalIOChannel):
-            raise PulseError(
-                "Cannot delay channel {0} because it is a classical IO channel.".format(
-                    channel.name
-                )
-            )
 
     @property
     def channel(self) -> Channel:

qiskit/pulse/instructions/directives.py

@@ -16,8 +16,6 @@
 from typing import Optional, Tuple
 
 from qiskit.pulse import channels as chans
-from qiskit.pulse.channels import ClassicalIOChannel
-from qiskit.pulse.exceptions import PulseError
 from qiskit.pulse.instructions import instruction
 
 
@@ -46,17 +44,7 @@ def __init__(self, *channels: chans.Channel, name: Optional[str] = None):
         Args:
             channels: The channel that the barrier applies to.
             name: Name of the directive for display purposes.
-        Raises:
-            PulseError: If one of the `channels` cannot be blocked because it is a classical IO channel.
         """
-        for channel in channels:
-            if isinstance(channel, ClassicalIOChannel):
-                raise PulseError(
-                    "Cannot block channel {0} because it is a classical IO channel.".format(
-                        channel.name
-                    )
-                )
-
         super().__init__(operands=tuple(channels), name=name)
 
     @property

qiskit/pulse/instructions/frequency.py

@@ -16,7 +16,7 @@
 from typing import Optional, Union, Tuple
 
 from qiskit.circuit.parameterexpression import ParameterExpression
-from qiskit.pulse.channels import PulseChannel
+from qiskit.pulse.channels import PulseChannel, PulseError
 from qiskit.pulse.instructions.instruction import Instruction
 
 
@@ -46,7 +46,13 @@ def __init__(
             frequency: New frequency of the channel in Hz.
             channel: The channel this instruction operates on.
             name: Name of this set channel frequency instruction.
+        Raises:
+            PulseError: If channel is not a PulseChannel.
         """
+        if not isinstance(channel, PulseChannel):
+            raise PulseError(
+                "The `channel` argument to `SetFrequency` must be of type `channels.PulseChannel`."
+            )
         if not isinstance(frequency, ParameterExpression):
             frequency = float(frequency)
         super().__init__(operands=(frequency, channel), name=name)

qiskit/pulse/instructions/phase.py

@@ -18,7 +18,7 @@
 from typing import Optional, Union, Tuple
 
 from qiskit.circuit import ParameterExpression
-from qiskit.pulse.channels import PulseChannel
+from qiskit.pulse.channels import PulseChannel, PulseError
 from qiskit.pulse.instructions.instruction import Instruction
 
 
@@ -52,7 +52,14 @@ def __init__(
             phase: The rotation angle in radians.
             channel: The channel this instruction operates on.
             name: Display name for this instruction.
+
+        Raises:
+            PulseError: If channel is not a PulseChannel.
         """
+        if not isinstance(channel, PulseChannel):
+            raise PulseError(
+                "The `channel` argument to `ShiftPhase` must be of type `channels.PulseChannel`."
+            )
         super().__init__(operands=(phase, channel), name=name)
 
     @property
@@ -108,7 +115,13 @@ def __init__(
             phase: The rotation angle in radians.
             channel: The channel this instruction operates on.
             name: Display name for this instruction.
+        Raises:
+            PulseError: If channel is not a PulseChannel.
         """
+        if not isinstance(channel, PulseChannel):
+            raise PulseError(
+                "The `channel` argument to `SetPhase` must be of type `channels.PulseChannel`."
+            )
         super().__init__(operands=(phase, channel), name=name)
 
     @property

qiskit/pulse/instructions/play.py

@@ -41,7 +41,7 @@ def __init__(self, pulse: Pulse, channel: PulseChannel, name: Optional[str] = No
             name: Name of the instruction for display purposes. Defaults to ``pulse.name``.
 
         Raises:
-            PulseError: If pulse is not a Pulse type.
+            PulseError: If pulse is not a Pulse type, or channel is not a PulseChannel.
         """
         if not isinstance(pulse, Pulse):
             raise PulseError("The `pulse` argument to `Play` must be of type `library.Pulse`.")