Macro housekeeping #448
Closed
Macro housekeeping #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notpeelz
force-pushed
the
dont-redefine-feature-test-macros
branch
2 times, most recently
from
57d7d97 to
8df0908
Compare
notpeelz
changed the title
notpeelz
force-pushed
the
dont-redefine-feature-test-macros
branch
from
8df0908 to
e39276e
Compare
- Don't redefine _GNU_SOURCE/_XOPEN_SOURCE in polkitbackend - Define _GNU_SOURCE via compiler options (instead of config.h) - Include config.h globally via compiler options - Bump meson version requirement to >= 1.4.0
notpeelz
force-pushed
the
dont-redefine-feature-test-macros
branch
from
e39276e to
9a38d32
Compare
|
Hello, thank you for your contributions! Could you please create a separate PR for each change (item in your description)? |
|
I initially had them as separate commits, but decided to squash them because the changes are tightly coupled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed feature test macro definitions (i.e
_GNU_SOURCE/_XOPEN_SOURCE) from polkitbackend because_GNU_SOURCEis already defined in the root meson.build.Explicitly defining
_XOPEN_SOURCEis redundant because_GNU_SOURCEimplies_XOPEN_SOURCE 700(according to the comments in glibc'sfeatures.h)I simplified the handling of
config.h; instead of having#include "config.h"in every file, we can use the compiler's-includeoption to do that for usI had to bump the meson version requirement to >=1.4.0 to use the
file.full_path()API.I moved the
-std=c99flag to the project'sdefault_options, as it appears to have been fixed (Make compilers list per subproject mesonbuild/meson#10170)