WeightsV2 support for contracts pallet

[niklabh]

Fixes: #8364

[jacogr]

Brilliant! Will take a peek in the morning.

[niklabh]

Please review.

[niklabh]

Hey @jacogr Can you please review. This is high priority for WASM Networks.

[forgetso]

I'm working with this PR locally and have spotted that the tool tips need updated for proofSize and refTime. They both currently have the same tooltip:

'The maximum amount of gas to use for this contract call. If the call requires more, it will fail.'

[honne23]

bumping because this is really needed for dev

[zabuxx]

Bump 🤗

[akorchyn]

Any updates on it?

[andrii-kl]

+1

[abhijeetbhagat]

+1

[PierreOssun]

+1

[KennethVrb]

+1

[forgetso]

Thanks for the update @niklabh. I also noticed that weight is mentioned on the block pages.

However, it's hard to work out what % of a block is populated based on refTime and proofSize without some official guidance. Maybe it's still the refTime divided by the maxBlock.refTime. Anyway, the above is calculated using ? weight.v1Weight.mul(BN_TEN_THOUSAND).div(maxBlockWeight).toNumber() / 100 currently.

[adamdossa]

Bumping as we'd also like this! @jacogr any idea when this might be merged?

[jacogr]

Thank you. Appreciate it.

Could you please merge in master, there are a lot of conflicts.

[niklabh]

Thank you. Appreciate it.

Could you please merge in master, there are a lot of conflicts.

Done

[forgetso]

A slight modification is needed to allow uploading contracts via .wasm and .json. When a .contract is uploaded the wasm is in Raw format. When the wasm is uploaded separately, it is a UInt8Array and the deploy fails with contracts.StorageDepositLimitExhausted. This can be fixed by modifying the dryRun function in Upload.tsx.

Change

              { Upload: wasm },

to

              { Upload: api.registry.createType('Raw', wasm) },

here

https://github.com/niklabh/apps/blob/0f6639ebac89c8c0ed6b79afd5b6cd770d03248d/packages/page-contracts/src/Codes/Upload.tsx#L99

Thanks for the PR @niklabh.

Stale.

[jacogr]

There are CI linting failures - https://github.com/polkadot-js/apps/actions/runs/4530817731/jobs/7980218839?pr=8538#step:4:508

As well as build failures - https://github.com/polkadot-js/apps/actions/runs/4530817731/jobs/7980219094?pr=8538#step:4:533

Both should be easy to resolve.

[niklabh]

A slight modification is needed to allow uploading contracts via .wasm and .json. When a .contract is uploaded the wasm is in Raw format. When the wasm is uploaded separately, it is a UInt8Array and the deploy fails with contracts.StorageDepositLimitExhausted. This can be fixed by modifying the dryRun function in Upload.tsx.

Change

              { Upload: wasm },

to

              { Upload: api.registry.createType('Raw', wasm) },

here

https://github.com/niklabh/apps/blob/0f6639ebac89c8c0ed6b79afd5b6cd770d03248d/packages/page-contracts/src/Codes/Upload.tsx#L99

Thanks for the PR @niklabh.

Done

[niklabh]

There are CI linting failures - https://github.com/polkadot-js/apps/actions/runs/4530817731/jobs/7980218839?pr=8538#step:4:508

As well as build failures - https://github.com/polkadot-js/apps/actions/runs/4530817731/jobs/7980219094?pr=8538#step:4:533

Both should be easy to resolve.

Fixed

Stale.

[polkadot-js-bot]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.