Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Ledger lookups via hash/apps only #5618

Merged
merged 5 commits into from
Jun 29, 2021
Merged

Adjust Ledger lookups via hash/apps only #5618

merged 5 commits into from
Jun 29, 2021

Conversation

jacogr
Copy link
Member

@jacogr jacogr commented Jun 16, 2021

No description provided.

Copy link
Member Author

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by @michalisFr

... a huge thank-you.

@jacogr jacogr merged commit 7c84bcc into master Jun 29, 2021
@jacogr jacogr deleted the jg-ledger-lookups branch June 29, 2021 14:23
@michalisFr
Copy link

michalisFr commented Jun 29, 2021

Test:

"Add via Ledger" shows for Polkadot, Kusama and Statemine. On other chains it does not (although I didn't check ALL of them).

Sending and balances tested with Polkadot XL app and Kusama lite version on Ledger Nano S

Also tested refreshing (both soft and hard) and the account was still there.

Didn't test:

  • Other derivation paths besides 0/0
  • Other browsers besides Chrome
    FYI @jacogr

@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jul 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants