Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds null check before accessing multisigs #10603

Merged
merged 1 commit into from
May 21, 2024

Conversation

gupnik
Copy link
Contributor

@gupnik gupnik commented May 21, 2024

No description provided.

Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable, was there a coinciding issue that was present, just so I can be aware?

@gupnik
Copy link
Contributor Author

gupnik commented May 21, 2024

Sounds reasonable, was there a coinciding issue that was present, just so I can be aware?

Thanks for the quick review!

Yeah, the omni node POC here doesn't work with the accounts section. Not sure why its the only one that returns it as undefined while the other templates continue to work though.

@TarikGul
Copy link
Member

Ahh okay makes sense, thanks so much for the PR. Actions are a bit degraded today so it will take a second before this can go in.

@TarikGul TarikGul merged commit 7edc3a4 into polkadot-js:master May 21, 2024
5 checks passed
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants