Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update try-runtime-cli #463

Merged
merged 18 commits into from
Oct 18, 2024
Merged

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Sep 26, 2024

@ggwpez ggwpez changed the title Update check-migrations.yml [DNM] Test try-runtime-cli Sep 26, 2024
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@@ -137,7 +137,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion {
spec_name: create_runtime_str!("statemine"),
impl_name: create_runtime_str!("statemine"),
authoring_version: 1,
spec_version: 1_003_000,
spec_version: 1_003_003,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We forgot to bump this and only bumped the feature-gated version above...

@ggwpez ggwpez marked this pull request as ready for review October 8, 2024 13:54
@ggwpez ggwpez changed the title [DNM] Test try-runtime-cli Update try-runtime-cli Oct 8, 2024
ggwpez added 2 commits October 8, 2024 16:33
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez
Copy link
Member Author

ggwpez commented Oct 17, 2024

bot merge

@ggwpez ggwpez mentioned this pull request Oct 17, 2024
1 task
@ggwpez
Copy link
Member Author

ggwpez commented Oct 17, 2024

/merge

@seadanda
Copy link
Contributor

I think it needs another review, my review isn't counted because I'm a rank 1 pleb

@ggwpez
Copy link
Member Author

ggwpez commented Oct 17, 2024

I think it needs another review, my review isn't counted because I'm a rank 1 pleb

Hm, its weird that the bot is not responding though. It should print some error.

@ggwpez
Copy link
Member Author

ggwpez commented Oct 17, 2024

/merge

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) October 17, 2024 15:41
@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

1 similar comment
@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@seadanda
Copy link
Contributor

Copy link
Contributor

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some last nitpicks and then this is good to go

CHANGELOG.md Outdated Show resolved Hide resolved
.github/workflows/check-migrations.yml Outdated Show resolved Hide resolved
@bkchr bkchr disabled auto-merge October 18, 2024 19:07
Co-authored-by: Bastian Köcher <[email protected]>
@ggwpez ggwpez enabled auto-merge (squash) October 18, 2024 23:01
@ggwpez ggwpez disabled auto-merge October 18, 2024 23:01
@ggwpez
Copy link
Member Author

ggwpez commented Oct 18, 2024

/merge

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) October 18, 2024 23:03
@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@fellowship-merge-bot fellowship-merge-bot bot merged commit 91a4498 into main Oct 18, 2024
50 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants